Use remove newlines filter #54
Conversation
|
I think the filter might be improved if the remove spaces behaviour would strip whitespaces at the beginning and end of lines, something matching a regex like: |
| {% macro parametersBlock types %}{% for type in types %}p{{forloop.counter}}: {{type}}{% if not forloop.last %}, {% endif %}{% endfor %}{% endmacro %} | ||
| {% macro argumentsBlock types %}{% for type in types %}p{{forloop.counter}}{% if not forloop.last %}, {% endif %}{% endfor %}{% endmacro %} | ||
| {% macro parametersBlock types %}{% filter removeNewlines:"false" %} | ||
| {% for type in types %} |
There was a problem hiding this comment.
Side note: I really wish Stencil had whitespace control like ejs & Liquid & other template engines, so that we could write {%- for type in types -%} and let the template engine remove leading whitespaces when we use the dash on the opening brackets of tags. I think Kyle still intends to add it for Stencil 1.0 but it's still not in yet?
If Stencil plans to add it soon we can wait, if Kyle thinks he'll need more time for that we could imagine using a simplified version of it (replacing ^\s*{%- with {% in the template text before passing it to Stencil), a bit hacky but would work in the meantime. Only worth it if whitespace control isn't planned to be added too Stencil proper anytime soon though, imho 😉
djbe
force-pushed
the
feature/use-remove-newlines-filter
branch
from
d19f312
to
935787b
Compare
|
Will update this once SwiftGen/StencilSwiftKit#48 is merged. |
djbe
force-pushed
the
feature/use-remove-newlines-filter
branch
from
1c3d43d
to
60de9ee
Compare
djbe
force-pushed
the
feature/use-remove-newlines-filter
branch
from
60de9ee
to
e9bb422
Compare
Updates the templates to use the new filter a bit.